Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: new Menu/Settings/Tools #2231

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Jun 9, 2024

Description

This PR revamps our Settings menus and icons. Splitting them into a new Menu navigation view, a sub view called Settings and a view called Tools.

It also adds a nodes icon to the connecting/loading screen so users can opt to switch nodes on startup.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis force-pushed the navigation-redux branch 4 times, most recently from 00b0e45 to a2052d3 Compare June 9, 2024 21:34
@kaloudis kaloudis changed the title WIP: navigation redux Navigation: new Menu/Settings/Tools Jun 9, 2024
@kaloudis kaloudis added this to the v0.9.0 milestone Jun 9, 2024
@kaloudis kaloudis marked this pull request as ready for review June 9, 2024 23:53
@kaloudis kaloudis merged commit 80e81a5 into ZeusLN:master Jun 10, 2024
3 checks passed
@kaloudis kaloudis deleted the navigation-redux branch June 10, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant