[BugFix] CLNRest Backend Fix for paid invoices

[newtonick]

Description

CLNRest backend fix.

Current master branch uses the /v1/listinvoices endpoint for involves and does a limit of 150 records by created index. Unfortunately this limit is for the first 150 invoices and not the last 150 invoices. This means nodes with more than 150 invoices in the current master branch won't show up in the Activity View.

Link to code:

zeus/backends/CLNRest.ts

Line 214 in 3e6cf77

this.postRequest('/v1/listinvoices', { limit: 150, index: 'created' });

The fix is to move to the sql endpoint and order by created_index DESC.

This pull request is categorized as a:

• New feature
• Bug fix
• Code refactor
• Configuration change
• Locales update
• Quality assurance
• Other

Checklist

• I’ve run yarn run tsc and made sure my code compiles correctly
• I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
• I’ve run yarn run prettier and made sure my code is formatted correctly
• I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

• No, I’m a fool
• Yes
• N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

• Android
• iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

• Embedded LND
• LND (REST)
• LND (Lightning Node Connect)
• Core Lightning (c-lightning-REST)
• LndHub
• [DEPRECATED] Core Lightning (Spark)
• [DEPRECATED] Eclair
• CLNRest

Locales

• I’ve added new locale text that requires translations
• I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

• Contributors will need to run yarn after this PR is merged in
• 3rd party dependencies have been modified:
  • verify that package.json and yarn.lock have been properly updated
  • verify that dependencies are installed for both iOS and Android platforms

Other:

• Changes were made that require an update to the README
• Changes were made that require an update to onboarding

[newtonick]

@kaloudis if there is a more "javascripty" way to name invoicelist let me know. The linter gave me grief about naming it invoices.

zeus/backends/CLNRest.ts
  235:17  error  Expected property shorthand  object-shorthand

[kaloudis]

This is fine as is.

nit: would camelCase the var name