Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(activities): handle and kill multiple chat process ids #439

Merged
merged 3 commits into from
May 31, 2024

Conversation

Zibbp
Copy link
Owner

@Zibbp Zibbp commented May 30, 2024

Resolves #437

@russelg
Copy link

russelg commented May 30, 2024

I've been thinking about this a bit. Wouldn't it be better to match on the chat output path rather than the stream name when we kill chat downloader?

@Zibbp
Copy link
Owner Author

Zibbp commented May 30, 2024

That's a good point. No other linux process uses the temporary chat file so it should be find to search by justthe tmp chat file path, instead of the just the channel or even the full process (chat_download https://twitch.tv/foo --output /tmp/foo.json).

@Zibbp Zibbp merged commit f561b80 into main May 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chat download fails for one channel
2 participants