formatting, reduce instances of CheckCompressed #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoeyZolotova
requested changes
Apr 29, 2019
ROM.cs
Outdated
| { | ||
| int i = 0; | ||
| for (; i < MMFileList.Count; i++) | ||
| while (i < MMFileList.Count) |
There was a problem hiding this comment.
Could this function be basically return MMFileList.FindIndex(file => RAddr => file.Addr && RAddr < file.End)
There was a problem hiding this comment.
Though actually the results would be different if the RAddr is not found. Currently it would return MMFileList.Count whereas what i said would return -1. Would that be a problem?
ZoeyZolotova
approved these changes
Apr 30, 2019
ZoeyZolotova
pushed a commit
that referenced
this pull request
May 9, 2019
replaced ugly filebrowser, added official gitignore (to not place packages in git)
ZoeyZolotova
added a commit
that referenced
this pull request
Sep 7, 2019
…ank blue rupee, milk bar chateau and milk, deku playground any day, honey and darling any day, kotake mushroom sale, pictograph contest standard/good photos, business scrub magic bean / green potion / blue potion purchase, zora hall stage lights, gorman bros milk purchase, gorman bros race day 3 milk, ocean spider house day 2 and 3 rewards, bad/good pictographs of Lulu. Rename item locations: Ocean Spider House Reward to Ocean Spider House Day 1 Reward; Deku Playground to Deku Playground Three Days; Honey and Darling to Honey and Darling Three Days; Pictograph Contest to Pictograph Contest Winner; Gorman Bros Race to Gorman Bros Race Day 1 or 2; Bank Reward #2 to Bank Reward #3. If shopsanity is enabled, kotake now acts as if you've already given her a mushroom, and will immediately offer to buy mushrooms from you. If skulltula tokens are randomized, the man that gives the ocean spider house reward will now only relocate downstairs after giving you a reward that cycle.
ZoeyZolotova
added a commit
that referenced
this pull request
Sep 13, 2019
…s will have top priority guaranteed hints if they contain an essential item: Great Fairy rewards, Town/Swamp Archery #2, Frog Choir, Beaver Race #2, Anju and Kafei. The following locations will have guaranteed hints if the algorithm runs out of higher priority locations: Beaver Race #1, Honey and Darling Three Days, Gossip Stones, Butler Race, Bank Reward #3. Stray Fairies and Skulltula Tokens can not be the only reason for a Way of the Hero hint, however they can prevent a region from being Foolish if they lead to a potentially useful reward. May need to tweak this in the future.
isghj5
added a commit
to isghj5/mm-rando
that referenced
this pull request
Jan 28, 2020
…n the wrong part of code but nothing works and the path forward is slow and daunting, considering prototype ZoeyZolotova#2 a failure, moving to ZoeyZolotova#3
isghj5
added a commit
to isghj5/mm-rando
that referenced
this pull request
Feb 5, 2020
…n the wrong part of code but nothing works and the path forward is slow and daunting, considering prototype ZoeyZolotova#2 a failure, moving to ZoeyZolotova#3
isghj5
added a commit
to isghj5/mm-rando
that referenced
this pull request
Feb 25, 2020
…n the wrong part of code but nothing works and the path forward is slow and daunting, considering prototype ZoeyZolotova#2 a failure, moving to ZoeyZolotova#3
ZoeyZolotova
added a commit
that referenced
this pull request
Mar 20, 2020
isghj5
added a commit
to isghj5/mm-rando
that referenced
this pull request
Apr 11, 2020
ZoeyZolotova
added a commit
that referenced
this pull request
Jun 11, 2020
…ired randomized item or song" to "must lead to a required randomized item". Reduce hint priority of Goron Race from 0 to -2 to bring it in line with some other hints. Set hint priority of Seahorses to -2. Add ability for competitive hints to be combined. When appropriate, the following locations will be combined into one hint: Aliens Defense and Cremia ("Ranch Sisters Defense"); Beaver Race #1 and Beaver Race #2 ("Beaver Races"); Town Archery #1 and Town Archery #2 ("Town Archery"); Swamp Archery #1 and Swamp Archery #2 ("Swamp Archery"); Ocean Spider House Day 1 Reward, Ocean Spider House Day 2 Reward and Ocean Spider House Day 3 Reward ("Ocean Spider House"); Deku Playground Three Days and Deku Playground Any Day ("Deku Playground"); Honey and Darling Three Days and Honey and Darling Any Day ("Honey and Darling").
saneki
pushed a commit
to saneki/mm-rando
that referenced
this pull request
Nov 21, 2022
MMR.Yaz: Fix CS8347 for recent .NET SDK/compilers by using scoped parameters for ref struct types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to do more to simplify writing to the game's internal files, but in the meantime I've added a new function called GetFileIndexForWriting that replaces all but a handful of AddrToFile into CheckCompressed calls. I also cleaned up some code and formatted some arrays