Document how to access typings π΅π»ββοΈ #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 70 70
Lines 645 645
Branches 124 178 +54
=======================================
Hits 598 598
Misses 47 47Continue to review full report at Codecov.
|
dfvalero
approved these changes
Mar 12, 2020
thegrinder
approved these changes
Mar 12, 2020
|
π This PR is included in version 2.12.1 π The release is available on: Your semantic-release bot π¦π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our types are not exported in the root of the package, given there's an issue with Webpack.
They're exported under
@zopauk/react-components/types, document that given people might be easily confused around it ππ»Issue
#212