bees: Defer full initialization until cmdline parser is done #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not touch BeesContext until really needed. As a safety, move its initialization after cmdline parsing. Then follow the proven design of adding the needed default value and apply it to BeesContext later. Also, let's set a flag when initialization after cmdline parsing is done so we know if we already want to log an exit code. Fixes: commit 23f3e4e Closes: Zygo#103 Signed-off-by: Kai Krakow <[email protected]>
|
Hmm, it's not yet quite done... During normal startup, log settings are still applied too late. But feel free to merge anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not touch BeesContext until really needed. As a safety, move its
initialization after cmdline parsing. Then follow the proven design of
adding the needed default value and apply it to BeesContext later.
Also, let's set a flag when initialization after cmdline parsing is done
so we know if we already want to log an exit code.
Fixes: commit 23f3e4e
Closes: #103
Signed-off-by: Kai Krakow [email protected]