Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: editor_plugin.h was moved to editor/plugins #629

Closed
wants to merge 1 commit into from
Closed

fix: editor_plugin.h was moved to editor/plugins #629

wants to merge 1 commit into from

Conversation

Lunatix89
Copy link
Contributor

Looks like editor/editor_plugin.h was moved to editor/plugins/ so the build fails with the latest master branch (see here: godotengine/godot#90975).

@Lunatix89
Copy link
Contributor Author

There is also another reference in modules/voxel/util/godot/classes/editor_interface.h but I'm not sure whether this needs to be fixed as well or not.
I'm also not sure whether it would be better to add a switch like "#if VERSION_MAJOR == 4 && VERSION_MINOR >= 3` because it would otherwise fail builds in older releases.

@Zylann
Copy link
Owner

Zylann commented Apr 29, 2024 •
edited
Loading

Should be fixed in 2c625a6 712f013

@Zylann Zylann closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lunatix89 @Zylann