Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use consistent hex prefix handling #246

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: use consistent hex prefix handling #246

merged 1 commit into from
Jan 10, 2024

Commits on Jan 9, 2024

  1. fix: use consistent hex prefix handling 

    Using [2:] to strip the "0x" prefix from hexstrings is problematic, because hex(int) or hexify(val) return 0x-prefixed strings, but bytes.hex() doesn't. So occasionally we would mistakenly eat the first byte instead of the prefix:

before: hex"487b710000000000000000000000000000000000000000000000000000000000000032"
after:  hex"4e487b710000000000000000000000000000000000000000000000000000000000000032"
    @karmacoma-eth
    karmacoma-eth committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    96a4813 View commit details
    Browse the repository at this point in the history