support for signing and verifying signatures #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ a bunch of tests for vm.addr() + move the known_keys and known_sigs to the Exec object, making it part of cheatcodes meant that tests could interfere with each other Still a WIP, the output of vm.sign() is not connected to ecrecover() yet
avoids relying on counters for name collisions and repeated vm.addr(x) applications are implicitly equal, no need to add explicit constraints
(under the right circumstances)
daejunpark
reviewed
Mar 18, 2024
calling vm.sign(key, digest) will now: - generate (v, r, s) - generate a constraint that ecrecover(digest, v, r, s) == vm.addr(key) - generate the same constraint for the equivalent signature this is simpler and more efficient than the previous way to do it entirely as constraints between ecrecover calls
karmacoma-eth
changed the title
daejunpark
reviewed
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
vm.addrvm.addrconsistent (keep track of minted addresses and reuse them)vm.labelmakeAddrAndKeyis supportedvm.signvm.signconsistentecrecoveroutput to known signaturesecrecoverimplicit output sizeOpen ended:
how do we handle signature malleability?(EDIT: ✅ supported)