Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bad abi encoding in createBytes4 #329

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

karmacoma-eth
Copy link
Collaborator

bytes4 must be right-padded with 0s, not left padded

Copy link
Collaborator

@daejunpark daejunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@karmacoma-eth karmacoma-eth merged commit 32b81ed into main Jul 23, 2024
56 checks passed
@karmacoma-eth karmacoma-eth deleted the fix-createBytes4 branch July 23, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants