feat: empty initial network state #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
karmacoma-eth
approved these changes
Aug 26, 2024
| def mk_this() -> Address: | ||
| # NOTE: Do NOT remove the `con_addr()` wrapper. | ||
| # The return type should be BitVecSort(160) as it is used as a key for ex.code. | ||
| # The keys of ex.code are compared using structural equality with other BitVecRef addresses. | ||
| return con_addr(magic_address + 1) | ||
| return con_addr(FOUNDRY_TEST) |
There was a problem hiding this comment.
might be nice to standardize on address() rather than con_addr(), wdyt?
There was a problem hiding this comment.
good idea. they are slightly different though right now--value range check only in con_addr. perhaps it would be better to add the value range check in the con(), and then replace con_addr() with address(). but we need to make sure this doesn't break others. let's work on it in a separate pr.
src/halmos/cheatcodes.py
Outdated
| @@ -687,7 +690,7 @@ def handle(sevm, ex, arg: ByteVec, stack, step_id) -> ByteVec | None: | |||
|
|
|||
| return ret | |||
|
|
|||
| # getBlockNumber() return (uint256) | |||
| # vm.getBlockNumber() return (uint256) | |||
| elif funsig == hevm_cheat_code.get_block_nunber_sig: | |||
There was a problem hiding this comment.
unrelated, but typo here
Suggested change
| elif funsig == hevm_cheat_code.get_block_nunber_sig: | |
| elif funsig == hevm_cheat_code.get_block_number_sig: |
There was a problem hiding this comment.
(needs to be fixed at definition site too)
There was a problem hiding this comment.
good catch, fixed, thanks!
Comment on lines
-168
to
-177
| symbolic_msg_sender: bool = arg( | ||
| help="set msg.sender symbolic", | ||
| global_default=False, | ||
| ) | ||
|
|
||
| no_test_constructor: bool = arg( | ||
| help="do not run the constructor of test contracts", | ||
| global_default=False, | ||
| ) | ||
|
|
There was a problem hiding this comment.
we're really cleaning up 🤗
| @@ -6,6 +6,10 @@ import "forge-std/Test.sol"; | |||
| contract DealTest is Test { | |||
| C c; | |||
|
|
|||
| function check_initial_balance(address addr) public { | |||
| assertEq(addr.balance, 0); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes: