Cleanup dense poly #151
Merged
Cleanup dense poly #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dev on |
sragss
reviewed
Jan 25, 2024
| @@ -122,7 +122,7 @@ where | |||
| fn batch(&self) -> Self::BatchedPolynomials { | |||
| use rayon::prelude::*; | |||
| let (batched_dim_read, (batched_final, batched_E, batched_flag)) = rayon::join( | |||
| || DensePolynomial::merge_dual(self.dim.as_ref(), self.read_cts.as_ref()), | |||
| || DensePolynomial::merge(&[self.dim.as_slice(), self.read_cts.as_slice()].concat()), | |||
There was a problem hiding this comment.
Can we drop the concat here?
I'm concerned that we're going to allocate a vector of length self.dim.len() + self.read_cts.len() twice. Once after the .concat() call and once in DensePolynomial::merge. Recall that these are likely to be massive (2^28 -> 2^32).
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly preparing for generalizing the PCS, which would require switching to
MultilinearExtensionfromark-polyand deprecating the customDensePolynomialused now.This PR should be useful regardless of whether the above happens or not:
merge_dualin favor of callingmergeon the concatenated slicesextendflag_msm&sm_msm) are not methods onDensePolynomialbut rather stand-alone functions. Moves them to themsmmodule.