Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server field and validation #10

Merged
merged 10 commits into from
Apr 18, 2024
Merged

Add server field and validation #10

merged 10 commits into from
Apr 18, 2024

Conversation

NickGreen
Copy link
Contributor

In this Pull Request

  • Added server input field back in
  • Updated the validation function to sanitize and validate the username and the server
SCR-20240416-ozed

Copy link
Contributor

@fmfernandes fmfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the username validation which I think we should account for the user providing only spaces, the other comments are mostly small nitpicks.

includes/settings.php Outdated Show resolved Hide resolved
includes/settings.php Outdated Show resolved Hide resolved
includes/settings.php Outdated Show resolved Hide resolved
@NickGreen
Copy link
Contributor Author

Based on the comment here, the settings screen now looks like this:

SCR-20240418-jces

@NickGreen
Copy link
Contributor Author

Merging this as a new version for testing.

@NickGreen NickGreen merged commit 9ed856f into trunk Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants