Add rules to check for DocBlock comments #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds rules to check for DocBlock comments in functions and classes.
Squiz.Commenting.FunctionComment
checks for the presence of@param
,@return
and@throws
tags and will also make sure function parameter names and descriptions are aligned like so:Currently there's no sniff to check for
@since
or@version
tags, so it also can not align them with@param
tags. Though, I believe it's still an advantage to check for the presence of a DocBlock comment.Generic.Commenting.DocComment
is added so we ensure each function has a description in the DocBlock. The rule above only checks tags, not the description itself. This rule also ensures a sentence starts with a capital letter and ends with a period.Squiz.Commenting.ClassComment
handles checks for a class but we need to disable checks for invalid tags, as we may want to have@since
and@version
, but that does mean a class with a@var
tag is valid.