Replace ambiguous code example in the documentation #178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
First thing first, thanks for this library and the tutorial.
The current wording is confusing: it says that the lines should be "added" to the
Application.module
function, but the code example underneath shows you the whole function, without theconfigureRouting()
call which is necessary to access the graphql playground.IMHO, we should simply tell the reader to either:
Application.module
function with whatever is displayed as a code example underneath (what I suggest in this PR)Application.module
and not to replace it for example:In this PR, I chose the first option, as it is the most straightforward, less error prone and easy to follow.