Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset not found #1

Open
wants to merge 3 commits into
base: aadl
Choose a base branch
from
Open

Asset not found #1

wants to merge 3 commits into from

Conversation

eby
Copy link
Member

@eby eby commented Aug 15, 2019

Mostly based of GRPL code:

  • Makes sure hold is cancelled before deleting the copy
  • Does check and logging in both places when asset copy isn't found.

This can be later simplified to just being in the copy_from_barcode but there isn't as much info accessible there to log right now.

Need to test the cgi in production and see if it handles these cases well. Probably should do a rebase commit to make this a single if it does.

@eby eby self-assigned this Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant