Configurable install path #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wp-cli strips global options from `$assoc_args` so it’s better to use our own for this.
dwillitzer
approved these changes
Oct 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #10, it may be desirable to be able to pass the path to the install directory when creating a new install. This was always the intention by referencing the global
--pathflag internally.However, what wasn't obvious is that WP-CLI strips all global options out of the
$assoc_argspassed to a subcommand. Even by defining it in the synopsis likecore downloadit will still be stripped unlessWP_CLI_STRICT_ARGS_MODEis enabled.Rather than messing with this, it makes much more sense to just use a different option as the behavior is a bit different anyways.
This PR adds a
--in=<dir>flag you can pass tovalet newwith a path to the desired install directory (ie: parent directory of the install). Because Valet uses the name of the install directory for the local domain name it is accessed with, the project directory will be installed inside the given path.i.e. If you were to run
wp valet new my-project --in=some/dirthe install directory would then be:./some/dir/my-projectwhich would be accessed athttps://my-project.dev