Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update extends error message #34

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Update extends error message #34

merged 1 commit into from
Jan 11, 2017

Conversation

dnephin
Copy link
Collaborator

@dnephin dnephin commented Jan 10, 2017

@shin-, @vdemeester

docker/compose#4315

The error message on extends was misleading. What do you think about this?

I'm not sure there is really anything else we can tell them about it.

@dnephin
Update extends error message.
cc623c0 
Signed-off-by: Daniel Nephin <[email protected]>
vdemeester
vdemeester approved these changes Jan 11, 2017
View reviewed changes
Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dnephin dnephin merged commit 8b762b2 into aanand:master Jan 11, 2017
@dnephin dnephin deleted the fix-extends-error-message branch January 11, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnephin @vdemeester