Fix timeout error by rate-limiting HTTP requests #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with X simultaneous requests I have 10 devices and now I am seeing all the requests complete successfully in a period of ~8 or so seconds (not tripping the timeout) by spacing out enough time. Perhaps the Bond Pro is overwhelmed and can only accept a small number of concurrent HTTP connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the
axios-rate-limitpackage to slow down initial requests long enough that the Bond Pro bridge does not become overwhelmed. Tested that this works fine locally and on my homebridge server.Unsure what the right simultaneous request limit and time limit is, but this was enough to avoid 10 second timeouts and get the devices to once again be responsive in the Home app.
Fixes #201