-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding workflow tests and fix installation in documentation #5
Conversation
Just complementing, for now, it wasn't possible to test versions earlier than NodeJS 14, because Mocha requires the NodeJS 14.0.0 or higher. |
Another point I haven't touched on, is Line 10 in 8498142
@aashutoshrathi, I don't think a polyfill is necessary, just set the engine in |
But I want to be sure that if we do the polyfill, will we be vulnerability free? As I think the polyfill uses regex |
So, it is okay to publish without |
Hey! @wellwelwel Can you point this PR to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you add the CI Badge too?
I'm away from PC now, but the |
Alright, but after I wake up 🙋🏻♂️ |
Closing in favor of: |
Hi @aashutoshrathi, I would like to contribute by automating existing tests for every new submitted PR and for pushes to
master
branch.About the
package-lock.json
(2,246 additions by performingnpm i
), it's necessary to install the correct packages and perform the CI tests.Also, I noticed two errors in
README.md
:word-wrap/README.md
Line 10 in 8498142
word-wrap/README.md
Line 16 in 8498142
Feel free to ask anything 🚀