Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding workflow tests and fix installation in documentation #5

Closed
wants to merge 7 commits into from
Closed

Conversation

wellwelwel
Copy link

@wellwelwel wellwelwel commented Jul 6, 2023

Hi @aashutoshrathi, I would like to contribute by automating existing tests for every new submitted PR and for pushes to master branch.

Having millions of downloads, it's good to always make sure nothing is broken with new changes (except when intentionally).


About the package-lock.json (2,246 additions by performing npm i), it's necessary to install the correct packages and perform the CI tests.

npm ci


Also, I noticed two errors in README.md:

$ npm install --save word-wrap

var wrap = require('word-wrap');

  • Then, I just fixed it to your npm package.

Feel free to ask anything 🚀

@wellwelwel
Copy link
Author

Just complementing, for now, it wasn't possible to test versions earlier than NodeJS 14, because Mocha requires the NodeJS 14.0.0 or higher.

@wellwelwel
Copy link
Author

wellwelwel commented Jul 6, 2023

Another point I haven't touched on, is trimEnd:

const trimmedLines = lines.map((line) => line.trimEnd());


@aashutoshrathi, I don't think a polyfill is necessary, just set the engine in package.json to >=10.3.0.
But I leave it to you decide.

@aashutoshrathi
Copy link
Owner

Another point I haven't touched on, is trimEnd:

const trimmedLines = lines.map((line) => line.trimEnd());

@aashutoshrathi, I don't think a polyfill is necessary, just set the engine in package.json to >=10.3.0. But I leave it to you decide.

But I want to be sure that if we do the polyfill, will we be vulnerability free? As I think the polyfill uses regex

@aashutoshrathi
Copy link
Owner

So, it is okay to publish without package-lock.json, but we need that for CI it, right?

@aashutoshrathi
Copy link
Owner

Hey! @wellwelwel Can you point this PR to v1.2.7 and take a pull of the same branch once.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you add the CI Badge too?

@wellwelwel
Copy link
Author

So, it is okay to publish without package-lock.json, but we need that for CI it, right?

I'm away from PC now, but the package-lock.json probably will be ignored because the files field into package.json.

@wellwelwel
Copy link
Author

Hey! @wellwelwel Can you point this PR to v1.2.7 and take a pull of the same branch once.

Alright, but after I wake up 🙋🏻‍♂️

@wellwelwel
Copy link
Author

@wellwelwel wellwelwel closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants