-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative to country list scroll #195
Open
MrSpiffyClean
wants to merge
15
commits into
aatishb:master
Choose a base branch
from
MrSpiffyClean:aside-scroll-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 20, 2020
-
Merge pull request #11 from aatishb/master
Update to most recent state
Configuration menu - View commit details
-
Copy full SHA for 944d7c8 - Browse repository at this point
Copy the full SHA 944d7c8View commit details
Commits on May 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f1ca9f3 - Browse repository at this point
Copy the full SHA f1ca9f3View commit details
Commits on May 22, 2020
-
Wrap the top elements of the Countries list such that they can stick on top.
Configuration menu - View commit details
-
Copy full SHA for 3a46d12 - Browse repository at this point
Copy the full SHA 3a46d12View commit details -
Add countriestopwrapper css info
.countriestopwrapper p needs to be at the bottom, after the other p declarations, because of specificity issues. It is needed because of margin/padding conflicts (e.g. collapsing margins). Also removing leftover .countries formatting relating to scrolling.
Configuration menu - View commit details
-
Copy full SHA for 1dffc64 - Browse repository at this point
Copy the full SHA 1dffc64View commit details -
Configuration menu - View commit details
-
Copy full SHA for ada0aad - Browse repository at this point
Copy the full SHA ada0aadView commit details -
Add customizetopwrapper and related func
customizetopwrapper and separator are sticky. countriestopwrapper was changed to accommodate the new sticky elements. Changing aside padding-top to allow for the customizetopwrapper to work seamlessly. min-width is removed from .search and .select, as they break the flow. (might change the width of aside to fix)
Configuration menu - View commit details
-
Copy full SHA for 00c6e41 - Browse repository at this point
Copy the full SHA 00c6e41View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc4b294 - Browse repository at this point
Copy the full SHA cc4b294View commit details -
This enables "scroll to top" when clicking the titles, allowing for easy going back-from the sections.
Configuration menu - View commit details
-
Copy full SHA for 60da578 - Browse repository at this point
Copy the full SHA 60da578View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71ed61b - Browse repository at this point
Copy the full SHA 71ed61bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cf64f6f - Browse repository at this point
Copy the full SHA cf64f6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f2cd7f - Browse repository at this point
Copy the full SHA 6f2cd7fView commit details
Commits on Jun 1, 2020
-
Added h2 hover formatting Changed some stuff in .separator and .countriestopwrapper
Configuration menu - View commit details
-
Copy full SHA for 1123a50 - Browse repository at this point
Copy the full SHA 1123a50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95f7445 - Browse repository at this point
Copy the full SHA 95f7445View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1733118 - Browse repository at this point
Copy the full SHA 1733118View commit details -
Configuration menu - View commit details
-
Copy full SHA for f27da65 - Browse repository at this point
Copy the full SHA f27da65View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.