Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per-capita option #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add per-capita option #25

wants to merge 2 commits into from

Conversation

jwosty
Copy link

@jwosty jwosty commented Mar 29, 2020

Addresses #1

@jwosty jwosty marked this pull request as ready for review March 29, 2020 22:24
@jwosty
Copy link
Author

jwosty commented Mar 29, 2020

This is ready for a review. I've added a dropdown where you can choose between cases "absolute" and "per capita".

@@ -0,0 +1,15 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file appears to be unrelated to this pull request

@@ -239,6 +243,11 @@ Vue.component('graph', {
this.$emit('update:day', this.dates.length);
},

selectedUnit() {
console.log('selectedUnit: ' + this.selectedUnit);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console logs?

if (urlParameters.has('unit')) {
let myUnit = urlParameters.get('unit').toLowerCase();

if (myUnit == 'per+capita') {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to +, %20 is a valid encoding of too, right?

@pleasehelpalex
Copy link

I was going to add a pro capita toggle! I'm happy you're already working on it! It would be great!

@nweldev
Copy link

nweldev commented Apr 15, 2020

FYI, you should read the comment @aatishb wrote on this topic some time ago: #30 (comment)

@aatishb
Copy link
Owner

aatishb commented Apr 16, 2020

Just want to remind folks of our code of conduct, which I’m excerpting here.

Be respectful. Disagreement is not an opportunity to attack someone else's thoughts or opinions. Although views may differ, remember to approach every situation with patience and care.

@nweldev
Copy link

nweldev commented Apr 16, 2020

@mrelg this was just an FYI. Nothing more than "hey BTW, there is a discussion about that, maybe it could be useful to read it". I personally run this branch locally on a daily bases, as it's useful to me alongside the version on the master. Yet, I understand and respect @aatishb work and opinion. Anyone who doesn't is free to run their own fork or better, to contribute to the discussion respectfully.

Repository owner deleted a comment from mrelg Apr 16, 2020
Repository owner deleted a comment from mrelg Apr 16, 2020
@aatishb
Copy link
Owner

aatishb commented Apr 16, 2020

@mrelg We have deleted your comments for being off-topic and not living up to our code of conduct.

Just to be clear, all of these comments are being posted on a public thread. As far as we can tell, @noelmace’s comment was not addressed to you but to the whole audience on this thread. You may inadvertently be getting email notifications from this comment thread, which you are free to unsubscribe from.

We will also be deleting any further off-topic comments. Just as a heads up, repeated code of conduct violations will result in being blocked from this repository.

@aatishb & @mustpax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants