Exposes US County Data #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdarfler
force-pushed
the
exposes-county-data
branch
from
425b164
to
bf69bde
Compare
|
I like the overall idea. It looks a lot like what I first had in mind until I thought it would be interesting to compare county-level data across states. For example, how would I combine King County, WA with New York City, NY on one plot? Can the states pull down be turned into a multiple selection option and have a county list from each (selected) one appear? |
|
That's an interesting question @sbonds. However, I'd suggest this be a follow on request to keep this PR small and targeted. |
bdarfler
force-pushed
the
exposes-county-data
branch
2 times, most recently
from
39aee14
to
ba7b987
Compare
The NYT data [methodology][1] differs from from the John Hopkins methodology. This change attempts to ensure consistency between the world data and the US data by using the John Hopkins CSSE data set for both. [1]: https://github.com/nytimes/covid-19-data#methodology-and-definitions
This adds a US Counties option which then exposes an additional drop down menu for selecting a US State. County level data is pulled from the John Hopkins CSSE data set and displayed for the selected State.
bdarfler
force-pushed
the
exposes-county-data
branch
from
ba7b987
to
55fd4d8
Compare
|
Rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44 @sbonds requested the addition of US County-level data. He graciously opened #46 to show a proof of concept.
Later @bsmith1180 opened #62 showing another possible UX for displaying the data and @imichaelmiers commented that the John Hopkins CSSE data might be a better source over the NYT data.
More recently @aatishb made a suggestion on yet a third way of organizing the UX.
In this Pull Request, I combine the suggestion from @imichaelmiers on #62 to use the John Hopkins CSSE data (building upon my PR #78 where I first introduce that data set) with @aatishb's suggestion on #44 of introducing a drop-down menu for state selection to reduce the visual clutter.
I'm happy to take any and all feedback. This can be merged in lieu of #78 or after #78, or not at all. I have pushed this code to my
gh-pagesbranch and the result can be viewed at https://bdarfler.github.io/covidtrends/