Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/upgrade test project to 4x #129

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Towfieee
Copy link

@Towfieee Towfieee commented Jan 3, 2024

  • I upgraded the test-project to newest godot version 4.2.1
  • I changed the code in the test project game to accommodate the deprecated parts.
  • I also modified the github workflow yml file to point to the latest docker images and godot-ci.
  • I also renamed the exported game files to better represent the targeted OS and serve as an example.

I tested the workflow godot-ci under my account. Here is the result:
Screenshot 2024-01-26 at 8 49 57 PM

I was also able to download the mac version of the game and run it locally:
Screenshot 2024-01-03 at 12 03 43 AM

@Towfieee Towfieee marked this pull request as draft January 3, 2024 03:20
@Towfieee Towfieee marked this pull request as ready for review January 3, 2024 05:06
@Calinou Calinou added the bug Something isn't working label Jan 3, 2024
@Calinou
Copy link
Collaborator

Calinou commented Jan 3, 2024

I commented out the web exported since it is broken at the moment. This needs to be a separate issue.

This is because GitHub Pages doesn't send the HTTP response headers required for SharedArrayBuffer to work, but Godot 4's web export currently requires it.

You could integrate the workaround listed here in your PR: #116

Godot 4.3 should have a no-threads export mode again like Godot 3.x, but you'll need to choose it in the web export preset for this to work.

@Towfieee
Copy link
Author

Towfieee commented Jan 4, 2024

I commented out the web exported since it is broken at the moment. This needs to be a separate issue.

This is because GitHub Pages doesn't send the HTTP response headers required for SharedArrayBuffer to work, but Godot 4's web export currently requires it.

You could integrate the workaround listed here in your PR: #116

Godot 4.3 should have a no-threads export mode again like Godot 3.x, but you'll need to choose it in the web export preset for this to work.

Although this might work, but it is downloading scripts from a third party url and allowing cross-origin-embedder-policy which can expose a security vulnerability for anyone viewing that page.

Should we just create another issue to track the web exporter issue. We can link people to the workaround but I don't think we should include it in our code.

@Towfieee
Copy link
Author

Towfieee commented Jan 27, 2024

I fixed the conflict with the master branch and retested the workflow.

I also uncommented the web export section

@Calinou Calinou force-pushed the feature/upgrade-test-project-to-4x branch from 49824f7 to 99743b3 Compare February 10, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants