-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/upgrade test project to 4x #129
base: master
Are you sure you want to change the base?
feature/upgrade test project to 4x #129
Conversation
This is because GitHub Pages doesn't send the HTTP response headers required for SharedArrayBuffer to work, but Godot 4's web export currently requires it. You could integrate the workaround listed here in your PR: #116 Godot 4.3 should have a no-threads export mode again like Godot 3.x, but you'll need to choose it in the web export preset for this to work. |
Although this might work, but it is downloading scripts from a third party url and allowing cross-origin-embedder-policy which can expose a security vulnerability for anyone viewing that page. Should we just create another issue to track the web exporter issue. We can link people to the workaround but I don't think we should include it in our code. |
I fixed the conflict with the master branch and retested the workflow. I also uncommented the web export section |
…comment it in the future
49824f7
to
99743b3
Compare
I tested the workflow godot-ci under my account. Here is the result:
I was also able to download the mac version of the game and run it locally: