Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ubuntu pipx installation by calling pip from python3 #71

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

tiagovrtr
Copy link
Contributor

@tiagovrtr tiagovrtr commented Mar 7, 2024

Fixes #68 by explicitly calling python3 -m pip install

Signed-off-by: Tiago Reis [email protected]

@tiagovrtr
Copy link
Contributor Author

Any news @abatilo ?

Copy link
Owner

@abatilo abatilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, somehow lost track of this. Looks good!

@abatilo abatilo changed the title Fix ubuntu pipx installation by calling pip from python3 fix: ubuntu pipx installation by calling pip from python3 May 7, 2024
@abatilo
Copy link
Owner

abatilo commented May 7, 2024

@tiagovrtr Can you try pushing an empty commit? None of the CI was ever triggered

@atkinsonm
Copy link

@tiagovrtr Can you try pushing an empty commit? None of the CI was ever triggered

@abatilo since the source is a fork you may have to approve running the CI actions https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks

@j-adamczyk
Copy link

Could this be merged? This bug broke our CI pipelines at https://github.com/scikit-fingerprints/scikit-fingerprints, and currently to do a release ASAP we basically have to remove this action altogether.

@abatilo
Copy link
Owner

abatilo commented Oct 27, 2024

Apologies everyone for the delay here. Merging! I'll address 3.8 failures separately since 3.8 is EoL anyways

@abatilo abatilo merged commit b35ab98 into abatilo:master Oct 27, 2024
83 of 85 checks passed
abatilo pushed a commit that referenced this pull request Oct 27, 2024
@rvgate
Copy link

rvgate commented Oct 28, 2024

Since this update my github actions have been failing, I was banging my head against the wall but the timing is too convenient;

    steps:
      - uses: actions/checkout@v4
      - uses: actions/setup-python@v5
        with:
          python-version: 3.12
      - uses: abatilo/[email protected]
        with:
          poetry-version: 1.8.4

Screenshot 2024-10-28 020114

abatilo added a commit that referenced this pull request Oct 28, 2024
A user reported that after the upgrade, there are failures. And this is
the only thing different in what they presented, so I wonder if there's
a change in v5 that causes the changes from #71 to fail.
@abatilo abatilo mentioned this pull request Oct 28, 2024
@abatilo
Copy link
Owner

abatilo commented Oct 28, 2024

@rvgate -- your failure appears to be from a step after this action ran. I'm not sure how much actions-poetry should be responsible for those steps, but I'm open to your opinions.

@rvgate
Copy link

rvgate commented Oct 28, 2024

@rvgate -- your failure appears to be from a step after this action ran. I'm not sure how much actions-poetry should be responsible for those steps, but I'm open to your opinions.

There are no other steps defined, it runs within the actions-poetry step and has been introduced with this PR;

f0a4db5

@rvgate
Copy link

rvgate commented Oct 28, 2024

It could be related to the OS, in the tests I see that only ubuntu, windows and macos are actively monitored. My runner is running on Fedora.

@weskerfoot
Copy link

I have the same issue, using Ubuntu 22.04. The error is coming from pipx install poetry==1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipx: command not found in v3 action
6 participants