-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ubuntu pipx installation by calling pip from python3 #71
Conversation
Any news @abatilo ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, somehow lost track of this. Looks good!
@tiagovrtr Can you try pushing an empty commit? None of the CI was ever triggered |
@abatilo since the source is a fork you may have to approve running the CI actions https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks |
Could this be merged? This bug broke our CI pipelines at https://github.com/scikit-fingerprints/scikit-fingerprints, and currently to do a release ASAP we basically have to remove this action altogether. |
Signed-off-by: Tiago Reis <[email protected]>
075ddc5
to
f0a4db5
Compare
Apologies everyone for the delay here. Merging! I'll address 3.8 failures separately since 3.8 is EoL anyways |
Signed-off-by: Tiago Reis <[email protected]>
Since this update my github actions have been failing, I was banging my head against the wall but the timing is too convenient;
|
A user reported that after the upgrade, there are failures. And this is the only thing different in what they presented, so I wonder if there's a change in v5 that causes the changes from #71 to fail.
@rvgate -- your failure appears to be from a step after this action ran. I'm not sure how much |
It could be related to the OS, in the tests I see that only ubuntu, windows and macos are actively monitored. My runner is running on Fedora. |
I have the same issue, using Ubuntu 22.04. The error is coming from |
Fixes #68 by explicitly calling
python3 -m pip install
Signed-off-by: Tiago Reis [email protected]