React hot loader compatibility #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this PR it no longer matters where the function lives in memory. glittershark/reactable#338
Tests passing
|
@abdulrahman-khankan are you an active PR reviewer on this repo? I don't see any default reviewers. |
|
@connorzg thank you for the PR 😃, I am just waiting for the weekend to look at it. |
abdulrahman-khankan
approved these changes
Jul 30, 2018
|
@connorzg Thank you for the PR. I have merged it, but currently there are problems with publishing to npm (their side). I will upload a new version there as soon as their service is back to normal. |
|
@connorzg it is now available from the npm registry with v1.1.0. |
|
Thanks @abdulrahman-khankan! This resolved the bug and our development process is fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See same issue from old repo glittershark/reactable#338
Tables currently won't render currently with react v16+ and RHL
parseChildData()compares functions directly, but React hot loader swaps out functions in memory meaning an inequality when determining type. This PR transitions type parsing to function string comparison.