Skip to content

Commit

Permalink
Turbopack build: Fix benchmark running with webpack (vercel#70533)
Browse files Browse the repository at this point in the history
Ensures there is no error running Tailwind with webpack in this
benchmark.

<!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:

## For Contributors

### Improving Documentation

- Run `pnpm prettier-fix` to fix formatting issues before opening the
PR.
- Read the Docs Contribution Guide to ensure your contribution follows
the docs guidelines:
https://nextjs.org/docs/community/contribution-guide

### Adding or Updating Examples

- The "examples guidelines" are followed from our contributing doc
https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md
- Make sure the linting passes by running `pnpm build && pnpm lint`. See
https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md

### Fixing a bug

- Related issues linked using `fixes #number`
- Tests added. See:
https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md

### Adding a feature

- Implements an existing feature request or RFC. Make sure the feature
request has been accepted for implementation before opening a PR. (A
discussion must be opened, see
https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added
(https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see
https://github.com/vercel/next.js/blob/canary/contributing.md


## For Maintainers

- Minimal description (aim for explaining to someone not on the team to
understand the PR)
- When linking to a Slack thread, you might want to share details of the
conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic
behind a change

### What?

### Why?

### How?

Closes NEXT-
Fixes #

-->
  • Loading branch information
timneutkens authored and abhi12299 committed Sep 29, 2024
1 parent c43aa2c commit 281f3cc
Show file tree
Hide file tree
Showing 6 changed files with 35 additions and 44 deletions.
6 changes: 3 additions & 3 deletions bench/heavy-npm-deps/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"lodash-es": "^4.17.21",
"lucide-react": "^0.383.0",
"mermaid": "^10.9.1",
"next": "workspace:*"
},
"devDependencies": {}
"next": "workspace:*",
"tailwindcss": "3.2.7"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ const config = {
},
}

export default config
module.exports = config
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import type { Config } from 'tailwindcss'

const config: Config = {
const config = {
content: [
'./pages/**/*.{js,ts,jsx,tsx,mdx}',
'./components/**/*.{js,ts,jsx,tsx,mdx}',
Expand All @@ -16,4 +14,4 @@ const config: Config = {
},
plugins: [],
}
export default config
module.exports = config
8 changes: 4 additions & 4 deletions packages/next/src/compiled/babel-packages/packages-bundle.js

Large diffs are not rendered by default.

55 changes: 24 additions & 31 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion scripts/devlow-bench.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ const nextBuildWorkflow =
'.next',
'cache',
'webpack',
'client-development'
'client-production'
)
await Promise.race([
waitForFile(join(cacheLocation, 'index.pack')),
Expand Down

0 comments on commit 281f3cc

Please sign in to comment.