Skip to content

Commit

Permalink
Remove deprecated ec2_elb fact (ansible-collections#827)
Browse files Browse the repository at this point in the history
elb_classic_lb - Remove deprecated ec2_elb fact

SUMMARY
Remove previously deprecated ec2_elb fact from elb_classic_lb this only every returned the value 'info'.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
elb_classic_lb
ADDITIONAL INFORMATION
See also ansible-collections#552 and ansible-collections#377 for some of the history.

Reviewed-by: Alina Buzachis <None>
  • Loading branch information
tremble authored May 25, 2022
1 parent 944bb1f commit 321038d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/552-elb_classic_lb-fact-remove.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
breaking_changes:
- elb_classic_lb - the ``ec2_elb`` fact has been removed (https://github.com/ansible-collections/amazon.aws/pull/827).
7 changes: 2 additions & 5 deletions plugins/modules/elb_classic_lb.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,8 @@
version_added: 2.1.0
notes:
- The ec2_elb fact currently set by this module has been deprecated and will no
longer be set after release 4.0.0 of the collection.
- The ec2_elb fact previously set by this module was deprecated in release 2.1.0 and since release
4.0.0 is no longer set.
extends_documentation_fragment:
- amazon.aws.aws
Expand Down Expand Up @@ -2147,10 +2147,7 @@ def main():
elb = elb_man.get_info()
ec2_result = dict(elb=elb)

ansible_facts = {'ec2_elb': 'info'}

module.exit_json(
ansible_facts=ansible_facts,
changed=elb_man.changed,
**ec2_result,
)
Expand Down

0 comments on commit 321038d

Please sign in to comment.