chore: generate checksum files after signing assets by codesign #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes checksums of assets for macOS. From colima v0.7.1, assets for macOS are signed by codesign. - 3415501 - #1094 But due to this checksums became invalid. ```console $ gh release download abiosoft/colima v0.7.1 $ cat *.sha256sum 9db4f5617eb3a16ef4abca4d515a7e81b80f7f8646a8c3fe50e4eb6e6e1a8ccb *colima-Darwin-arm64 e136336f3b000fda729f4266d1af573dcf3378568d4c5433c6b63350f960f296 *colima-Darwin-x86_64 f866550da41a4d1df7437fbf2e42449e213281ac1784d2f4d905e7bd13c5c772 *colima-Linux-aarch64 95cdef8ffc9fa2620a9a4c0771c4eab727b5d654341a0b6fcc70842c2bc38486 *colima-Linux-x86_64 $ sha256sum colima-Darwin-arm64 colima-Darwin-x86_64 colima-Linux-aarch64 colima-Linux-x86_64 df99434b42f0f85da5fa86063f86d7e818a19fcb46da528fe4201d9f6356744e colima-Darwin-arm64 abdf3069c8e6d35b1b23730cb320729eb53800b1049a4973f550e1ee4f62fa99 colima-Darwin-x86_64 f866550da41a4d1df7437fbf2e42449e213281ac1784d2f4d905e7bd13c5c772 colima-Linux-aarch64 95cdef8ffc9fa2620a9a4c0771c4eab727b5d654341a0b6fcc70842c2bc38486 colima-Linux-x86_64 ``` codesign changed assets, so we need to generate checksum files after running codesign.
suzuki-shunsuke
changed the title
|
That was an oversight from me, thanks :) |
abiosoft
previously approved these changes
Aug 13, 2024
|
Oh, CI failed. https://github.com/abiosoft/colima/actions/runs/10362231450/job/28687272447?pr=1105 |
|
You need to move the OS check as well so it only runs on macOS. |
ab6d802 Fixed. |
abiosoft
approved these changes
Aug 13, 2024
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 15, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [abiosoft/colima](https://github.com/abiosoft/colima) | patch | `v0.7.1` -> `v0.7.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>abiosoft/colima (abiosoft/colima)</summary> ### [`v0.7.3`](https://github.com/abiosoft/colima/releases/tag/v0.7.3) [Compare Source](abiosoft/colima@v0.7.2...v0.7.3) #### Highlights This is an hotfix release to address crashes during startup on macOS Sequoia 15 beta for M1 and M2 devices. [#​1109](abiosoft/colima#1109) #### Commits - cli: fix broken flag for non-m3 devices on macOS 15 by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1110 **Full Changelog**: abiosoft/colima@v0.7.2...v0.7.3 ### [`v0.7.2`](https://github.com/abiosoft/colima/releases/tag/v0.7.2) [Compare Source](abiosoft/colima@v0.7.1...v0.7.2) #### Highlights This is an hotfix release to address regressions introduced in v0.7.1. #### Fixes - Incorrect checksum for macOS binaries on Github releases. Fixes [#​1106](abiosoft/colima#1106) - Port mapping to specific host IP addresses has been moved behind `--network-host-addresses` flag and disabled by default. Fixes [#​1103](abiosoft/colima#1103) #### Commits - chore: generate checksum files after signing assets by codesign by [@​suzuki-shunsuke](https://github.com/suzuki-shunsuke) in abiosoft/colima#1105 - net: put host ip address replication behind a flag by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1107 #### New Contributors - [@​suzuki-shunsuke](https://github.com/suzuki-shunsuke) made their first contribution in abiosoft/colima#1105 **Full Changelog**: abiosoft/colima@v0.7.1...v0.7.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes checksums of assets for macOS.
From colima v0.7.1, assets for macOS are signed by codesign.
But due to this checksums became invalid.
codesign changed assets, so we need to generate checksum files after running codesign.