fix: invoke result.success after pushReset
#479
Conversation
|
Nice fix 👍 |
| @@ -648,6 +648,7 @@ private void pushReset(@NonNull MethodCall call, @NonNull MethodChannel.Result r | |||
| instanceStore.getPush(ablyMessage.handle) | |||
| .getActivationContext() | |||
| .reset(); | |||
There was a problem hiding this comment.
The main problem with reset is that it clears ably client from activationContext and it breaks everything until app is reloaded. There are 2 possible solutions:
- Reinstall ably client in flutter (I've checked locally and it works)
instanceStore.getPush(ablyMessage.handle)
.getActivationContext().setAbly((AblyRest) instanceStore.getAblyClient(ablyMessage.handle));- Do not clear ably client in reset (it looks for me that it is unnecessary, because ably client doesn't store any state) PR here
There was a problem hiding this comment.
Based on my observations while reading the code, I understood that reset breaks activation/deactivation state machine. It was never been a proper solution to the problem. As per PR (#357), it was introduced as an experimental feature that was never tested as such and I couldn't see any test cases available for the same
There was a problem hiding this comment.
@sacOO7 actually reset works in one particular very specific scenario: when ably environment has changed. If this happened activate/deactivate stop working. I agree that it's not very good solution, but it looks like it works. Basically it doesn't break state machine it simple delete it and recreate.
To avoid timeouts invoke
result.successafterpushReset