Add check if the directory exist #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs/node#37216 In the future version of node, rmdirSync fails when the directory does not exist This change make sure our script doesn't break after we upgrade node.
dpiatek
approved these changes
Mar 8, 2022
Glazy
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket Link / Motivation
nodejs/node#37216
In the future version of node, rmdirSync fails when the directory does not exist
This change make sure our script doesn't break after we upgrade node.
Summary of changes
See commits for details.
How do you manually test this?
Run the script node 16 or higher
Reviewer Tasks (optional)
Merge/Deploy Checklist
Frontend Checklist