Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiper-isearch in org-mode does not fold back #2457

Closed
ilautar opened this issue Feb 13, 2020 · 3 comments
Closed

swiper-isearch in org-mode does not fold back #2457

ilautar opened this issue Feb 13, 2020 · 3 comments
Labels

Comments

@ilautar
Copy link

ilautar commented Feb 13, 2020

Scenario:

  1. have org-mode with folded trees (with content below those trees)
  2. start swiper-isearch and search for something that matches what is INSIDE tree (ie., case where first match matches text on top lvl works fine)
  3. first match will unfold tree that matches in searched buffer
  4. pressing C-g will cancel search, return cursor where it was before search, but will NOT fold the newly unfolded (by swiper-isearch first match) tree

The same behaviour is also for any match, not just first one, if you C-n to it to show in original buffer and then press C-g.

Test case:

  1. use the following content for org file, fold all items
* HEADING 1
** test1
* HEADING 2
** test2
* HEADING 3
** test3
  1. swiper-isearch for "test"
  2. C-g
  3. HEADING 1 stays unfolded

Environment: Mac OSX 10.11.6, Emacs -Q, Emacs 26.3, swiper 20200122.1153, ivy 20200211.1338

@abo-abo
Copy link
Owner

abo-abo commented Feb 27, 2020

Hi. I can't reproduce the bug with swiper-isearch when using make plain from this repo. But I could reproduce it for swiper, and it should now be fixed.

Please check with make plain and with your config.

@basil-conto
Copy link
Collaborator

Is this still an issue?

@ilautar
Copy link
Author

ilautar commented May 3, 2020

Works now. Swiper version 5f1d9ce (from git repo by doom emacs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants