ivy-completion-in-region: correctly calculate the length of replacement for file category #3051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiennq
force-pushed
the
fix/completion-prefix-len
branch
from
7b6a90e
to
4f906b7
Compare
…nt for file category
kiennq
force-pushed
the
fix/completion-prefix-len
branch
from
4f906b7
to
2ab47b0
Compare
|
Thanks! I'll try to have a closer look at this soon. In the meantime, I'm curious: does this relate at all to the issues described in #1755? |
Yes, it should address that issue. The first item is actually used to fix that.
|
TristanCacqueray
added a commit
to podenv/devenv
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completions-first-difference, rather than a list of them.filecategory completions, calculate the prefix offset from the file name directory, not the entire input string. This adjustment is necessary because fuzzy completion styles can lead to incorrect common length values. The prefix offset ensures that we replace only the relevant portion of the input when calculating completion items.