Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolving requirements with percent encoded characters #144

Merged
merged 7 commits into from
Oct 30, 2023

Commits on Oct 10, 2023

  1. Fix several dependency resolution tests

    Update the assertions to re-align with changed dependency trees.
    
    Signed-off-by: Frank Viernau <[email protected]>
    fviernau committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2476c73 View commit details
    Browse the repository at this point in the history
  2. Re-generate test data

    This fixes several test cases in e.g. `test_cli.py`, `test_apy.py`.
    
    Signed-off-by: Frank Viernau <[email protected]>
    fviernau committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b2adca8 View commit details
    Browse the repository at this point in the history
  3. Fix resolving requirements with percent encoded characters

    `Distribution.from_link()` derives the version string of a package from
    the given (percent encoded) `Link.url`. That derivation lacks the
    decoding, so the resulting version string may also contain percent
    encoded characters in which case the dependency resolution fails.
    
    Fix the resolution by URL adding the missing unquoting.
    
    Fixes aboutcode-org#143.
    
    Signed-off-by: Frank Viernau <[email protected]>
    fviernau committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8c73d8d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    37b37c4 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Resolve quoted names in requirements aboutcode-org#143

    Move the resolution to the from_filename() method in subclasses
    
    Reference: aboutcode-org#143
    Signed-off-by: Philippe Ombredanne <[email protected]>
    pombredanne committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1298af8 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Add new tests for unquoted/quoted names aboutcode-org#143

    These new test were missing originally and they excercise all the
    corner cases of encoding.
    
    Reference: aboutcode-org#143
    Signed-off-by: Philippe Ombredanne <[email protected]>
    pombredanne committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    8a3558f View commit details
    Browse the repository at this point in the history
  2. Refine and use --generic-paths option in tests

    * Ensure that we honor the --generic-paths option when converting to
    plain mapping.
    
    * Avoid recursive imports by moving remove_test_data_dir_variable_prefix
    to utils.py
    
    * Simplifify tests to bypass the creation of an output file when not
    needed
    
    * Some tests are also updated to account for package version updates.
    
    Reference: aboutcode-org#143
    Signed-off-by: Philippe Ombredanne <[email protected]>
    pombredanne committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    11716a6 View commit details
    Browse the repository at this point in the history