Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python3.12 #174

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Add support for Python3.12 #174

merged 5 commits into from
Mar 28, 2024

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented Mar 28, 2024

No description provided.

@tdruez tdruez requested a review from TG1999 March 28, 2024 07:11
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have a test in 'test_resolution.py' to validate if our resolutions can take python version 3.12 as a valid input and do the resolutions

Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
Signed-off-by: Tushar Goel <[email protected]>
@TG1999
Copy link
Contributor

TG1999 commented Mar 28, 2024

I am merging this, there is likely a black heisenbug that only is in python 3.12, I am not able to recreate this bug locally with 3.12.

Signed-off-by: Tushar Goel <[email protected]>
@TG1999 TG1999 merged commit b4fa534 into main Mar 28, 2024
3 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants