Remove the dependency on Metaflow #82 #89
Conversation
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
Signed-off-by: Thomas Druez <[email protected]>
| """ | ||
| Indent each line of the provided `text`. | ||
| """ | ||
| return sep.join(" " * by + line for line in text.split(sep)) |
There was a problem hiding this comment.
Could this be a job for the stdlib textwrap? https://docs.python.org/3/library/textwrap.html
There was a problem hiding this comment.
Yes, thanks for the tip.
| if exitcode == 0: | ||
| return True | ||
| return False | ||
|
|
||
|
|
||
| def pipeline_graph_dot(pipeline_class, fontname="Helvetica", shape="record"): |
There was a problem hiding this comment.
I wonder if in the future we could eschew using dot at all.
There was a problem hiding this comment.
We can get rid of the feature now we have a way to visualize Pipeline in the UI.
|
|
||
| self.stdout.write(f"Pipeline {run.pipeline} run in progress...") |
There was a problem hiding this comment.
This is the default Django management command API https://docs.djangoproject.com/en/3.1/howto/custom-management-commands/#module-django.core.management
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
we are missing out the direct execution of a pipeline, but I will not miss this at all. A proper managed CLI is better.
|
|
||
| class DoNothing(Pipeline): | ||
| """ | ||
| A pipeline that does nothing, in 2 steps. |
Signed-off-by: Thomas Druez <[email protected]>
|
BTW, we may need to update the documentation accordingly? |
|
@pombredanne the only reference to Metaflow in the docs is this one:
|
No description provided.