Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare strict types and enforce them, fixes #679 #725

Closed
wants to merge 1 commit into from

Conversation

Zerquix18
Copy link
Contributor

Here I declare strict types and also enforce them. It fixes #679 and helps with #678

Things to consider:

  • Some functions take several types of params (e.g array and objects). I think we can try to reduce them to just one. I did not set a type for those params.
  • Some functions return several types of params (e.g array and objects). I think we can we just one as well. I dislike the idea that sometimes it returns an object and sometimes an array, and this has broken my code sometimes. We can open a separate issue for these.

Hope this contribution is useful 😄

@abraham
Copy link
Owner

abraham commented Oct 9, 2018

Awesome! Thank you. I'll get this merged one v1 is released.

@abraham
Copy link
Owner

abraham commented Apr 26, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable strict_types and add type declarations
2 participants