Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Device report 0% charge if additional batteries already exist #11

Open
forderud opened this issue Aug 28, 2024 · 5 comments
Open

Windows: Device report 0% charge if additional batteries already exist #11

forderud opened this issue Aug 28, 2024 · 5 comments

Comments

@forderud
Copy link
Contributor

forderud commented Aug 28, 2024 •
edited
Loading

First, thanks a lot for sharing this project!

I noticed that the Arduino device always shows up as a battery with 0% charge when testing in Windows on a laptop that already has a battery.
image

Work-around

It appear to be possible to work around this problem by disabling the real battery device in Device Manager:
image
The remaining Arduino battery then afterwards shows up with correct charge:
single battery

ASK: It would be great if the device could show up with correct charge also on multi-battery setups. I'm not sure, but have a feeling that this can be achieved by tweaking some HID parameters.
@abratchik
Copy link
Owner

abratchik commented Aug 28, 2024 •
edited
Loading

You are welcome. This is known issue, unfortunately.

Windows 10 does allow multiple batteries in the system and all of them can be displayed in the tray. However, the batteries must report their status in the same mode (HID specification supports maH, mwH and percentage) but most of UPS are only reporting percentage of charge. If you already have ACPI battery in your system (let's say you are testing on a laptop) then the percentage may not be reflected correctly.

You may change the units in the sketch how the remaining charge is reported and this will fix the issue but it will be valid only for the Windows host with the ACPI battery.

@forderud
Copy link
Contributor Author

forderud commented Aug 29, 2024 •
edited
Loading

You may change the units in the sketch how the remaining charge is reported and this will fix the issue but it will be valid only for the Windows host with the ACPI battery.

I just tested changing HID_PD_CAPACITYMODE from 2 (%) to 1 (mwH) and it did indeed fix the problem. Thanks a lot for the tip! I fully understand that all values here are artificial, so whether or not the aggregated battery capacity % for all batteries reported by Windows is correct or not doesn't really matter for me. I'm just interested in making the capacity always show up on screen.

Are you interested in updating the UPS.ino example with this change? If so, then I can submit a PR on it.

@abratchik
Copy link
Owner

Well, if your fix is tested on Linux, Mac and Windows then of course I will accept, why not? :-) Will be happy to.

@forderud
Copy link
Contributor Author

Well, if your fix is tested on Linux, Mac and Windows then of course I will accept, why not? :-) Will be happy to.

Great! However, it will take me some days to test on all those platforms. Will get back to you when I'm done.

forderud added a commit to forderud/HIDPowerDevice that referenced this issue Aug 29, 2024
@forderud
Change CapacityMode from 2 (%) to 0 (mAh)
7c60bee 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Aug 29, 2024
@forderud
Change CapacityMode from 2 (%) to 0 (mAh)
c9611f3 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery.
@forderud forderud mentioned this issue Aug 29, 2024
Closed
@forderud
Copy link
Contributor Author

forderud commented Aug 29, 2024 •
edited
Loading

See #14 for a proposed fix this this annoyance.

forderud added a commit to forderud/HIDPowerDevice that referenced this issue Aug 30, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
24f2a1b 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery.
@forderud forderud mentioned this issue Aug 30, 2024
Closed
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Sep 3, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
e840dde 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Sep 3, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
3743e0a 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery. This makes the sample more interesting to demonstrate.

The `CapacityMode` units are documented in [Usage Tables for HID Power Devices](https://www.usb.org/sites/default/files/pdcv11.pdf) section 4.2.3 Battery Controls.

The total battery charge % reported by Windows appear to be a weighted sum of each battery, weighted by their respective capacities. The Arduino battery is currently harcoded to `iFullChargeCapacity = 100` mWh, which is quite small. It does therefore have a relatively low influence on the total battery charge % on the laptop I've tested on.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Sep 9, 2024
@forderud
Document how report charge percentage of Windows laptops with existin…
20e4b2c 
…g batteries

See abratchik#11 and abratchik#14 for background.
@forderud forderud mentioned this issue Sep 9, 2024
Merged
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Sep 9, 2024
@forderud
Document how report charge percentage of Windows laptops with existin…
92cd3bc 
…g batteries

See abratchik#11 and abratchik#14 for background.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Sep 9, 2024
@forderud
Document how report charge percentage of Windows laptops with existin…
b7aacb5 
…g batteries

See abratchik#11 and abratchik#14 for background.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Sep 16, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
8793d25 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery. This makes the sample more interesting to demonstrate.

The `CapacityMode` units are documented in [Usage Tables for HID Power Devices](https://www.usb.org/sites/default/files/pdcv11.pdf) section 4.2.3 Battery Controls.

The total battery charge % reported by Windows appear to be a weighted sum of each battery, weighted by their respective capacities. The Arduino battery is currently harcoded to `iFullChargeCapacity = 100` mWh, which is quite small. It does therefore have a relatively low influence on the total battery charge % on the laptop I've tested on.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Sep 29, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
e6b3ab0 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery. This makes the sample more interesting to demonstrate.

The `CapacityMode` units are documented in [Usage Tables for HID Power Devices](https://www.usb.org/sites/default/files/pdcv11.pdf) section 4.2.3 Battery Controls.

The total battery charge % reported by Windows appear to be a weighted sum of each battery, weighted by their respective capacities. The Arduino battery is currently harcoded to `iFullChargeCapacity = 100` mWh, which is quite small. It does therefore have a relatively low influence on the total battery charge % on the laptop I've tested on.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Oct 13, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
4f1ddf7 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery. This makes the sample more interesting to demonstrate.

The `CapacityMode` units are documented in [Usage Tables for HID Power Devices](https://www.usb.org/sites/default/files/pdcv11.pdf) section 4.2.3 Battery Controls.

The total battery charge % reported by Windows appear to be a weighted sum of each battery, weighted by their respective capacities. The Arduino battery is currently harcoded to `iFullChargeCapacity = 100` mWh, which is quite small. It does therefore have a relatively low influence on the total battery charge % on the laptop I've tested on.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Oct 14, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
c0a091d 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery. This makes the sample more interesting to demonstrate.

The `CapacityMode` units are documented in [Usage Tables for HID Power Devices](https://www.usb.org/sites/default/files/pdcv11.pdf) section 4.2.3 Battery Controls.

The total battery charge % reported by Windows appear to be a weighted sum of each battery, weighted by their respective capacities. The Arduino battery is currently harcoded to `iFullChargeCapacity = 100` mWh, which is quite small. It does therefore have a relatively low influence on the total battery charge % on the laptop I've tested on.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Oct 15, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
032eb0b 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery. This makes the sample more interesting to demonstrate.

The `CapacityMode` units are documented in [Usage Tables for HID Power Devices](https://www.usb.org/sites/default/files/pdcv11.pdf) section 4.2.3 Battery Controls.

The total battery charge % reported by Windows appear to be a weighted sum of each battery, weighted by their respective capacities. The Arduino battery is currently harcoded to `iFullChargeCapacity = 100` mWh, which is quite small. It does therefore have a relatively low influence on the total battery charge % on the laptop I've tested on.

DISCLAIMER: This also changes the DesignedCapacity & FullChargedCapacity reported by Windows from 100 to 361. I don't understand why.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Oct 17, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
869de47 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery. This makes the sample more interesting to demonstrate.

The `CapacityMode` units are documented in [Usage Tables for HID Power Devices](https://www.usb.org/sites/default/files/pdcv11.pdf) section 4.2.3 Battery Controls.

The total battery charge % reported by Windows appear to be a weighted sum of each battery, weighted by their respective capacities. The Arduino battery is currently harcoded to `iFullChargeCapacity = 100` mWh, which is quite small. It does therefore have a relatively low influence on the total battery charge % on the laptop I've tested on.

This also implies changing the FullChargeCapacity & DesignCapacity units to AmpSec with 24bit parameter size as documented in the HID Power Device standard.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Nov 7, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
6a165a4 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery. This makes the sample more interesting to demonstrate.

The `CapacityMode` units are documented in [Usage Tables for HID Power Devices](https://www.usb.org/sites/default/files/pdcv11.pdf) section 4.2.3 Battery Controls.

The total battery charge % reported by Windows appear to be a weighted sum of each battery, weighted by their respective capacities. The Arduino battery is currently harcoded to `iFullChargeCapacity = 100` mWh, which is quite small. It does therefore have a relatively low influence on the total battery charge % on the laptop I've tested on.
forderud added a commit to forderud/HIDPowerDevice that referenced this issue Nov 7, 2024
@forderud
Change CapacityMode from 2 (%) to 1 (mWh)
e8f42b2 
This fixes abratchik#11 by also reporting battery capacity percentage on Windows laptops that already has a battery. This makes the sample more interesting to demonstrate.

The `CapacityMode` units are documented in [Usage Tables for HID Power Devices](https://www.usb.org/sites/default/files/pdcv11.pdf) section 4.2.3 Battery Controls.

The total battery charge % reported by Windows appear to be a weighted sum of each battery, weighted by their respective capacities. The Arduino battery is currently harcoded to `iFullChargeCapacity = 100` mWh, which is quite small. It does therefore have a relatively low influence on the total battery charge % on the laptop I've tested on.

This also implies changing the FullChargeCapacity & DesignCapacity units to AmpSec with 24bit parameter size as documented in the HID Power Device standard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@forderud @abratchik