Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABSL_PROPAGATE_CXX_STD does not set standard correctly #1116

Closed
h-vetinari opened this issue Mar 5, 2022 · 4 comments
Closed

ABSL_PROPAGATE_CXX_STD does not set standard correctly #1116

h-vetinari opened this issue Mar 5, 2022 · 4 comments
Labels
bug

Comments

@h-vetinari
Copy link
Contributor

Abseils ABI depends on the standard version used to compile (e.g. around string_view), so propagating the standard requirement of the produced binaries should reflect the standard used to compile. Currently it is set to the meta-feature cxx_std_11 unconditionally.

It might also be a good idea to add this to the windows DLL build.
@h-vetinari h-vetinari added the bug label Mar 5, 2022
@h-vetinari h-vetinari mentioned this issue Mar 5, 2022
Closed
@h-vetinari
Copy link
Contributor Author

This should have been closed by 308bbf3, but AFAICT, the C++ standard is not propagated for shared windows builds (see CMake/AbseilDll.cmake), c.f. also the diff of #1117

CC @coryan

@coryan
Copy link

coryan commented Oct 31, 2022

Doh! Apologies. I have prepared a change in the internal SCM. I expect I should be able to send it for review later today.

@coryan
Copy link

coryan commented Oct 31, 2022

@h-vetinari let me know if the changes don't work.

@h-vetinari
Copy link
Contributor Author

@h-vetinari let me know if the changes don't work.

Thanks for the super-quick handling! :)

@rmccorm4 rmccorm4 mentioned this issue Mar 2, 2023
Merged
netkex pushed a commit to netkex/abseil-cpp that referenced this issue Apr 3, 2024
@netkex
CMake: installed artifacts reflect the compiled ABI
4fad066 
In a previous change, I forgot to fix the DLLs to
also set the target_compile_features() as needed.

Some amount of refactoring to expose the necessary
variables and functions in AbseilDll.cmake

Fixes abseil#1116

PiperOrigin-RevId: 485101834
Change-Id: I5cd0eff9e20c0ddf48c364f917e40d66df0aac17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate CXX version used to compile abseil h-vetinari/abseil-cpp
2 participants
@coryan @h-vetinari