Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Annotate errors for Github #2328

Merged
merged 4 commits into from
Oct 2, 2024
Merged

CI: Annotate errors for Github #2328

merged 4 commits into from
Oct 2, 2024

Conversation

@runephilosof-abtion
Copy link
Member Author

The annotations are not visible on "conversation" tab of a PR.
image

But they are visible on "Files changed"
image

@jeppester
Copy link
Contributor

Looks like a fine little improvement.
To ensure that the rspec formatter works, could you make a commit that breaks rspec?

@runephilosof-abtion
Copy link
Member Author

Made rspec fail in #2329
It annotates the rspec files with the errors, instead of the place where the error is raised, but I guess it is better than not annotating.

image

@runephilosof-abtion runephilosof-abtion marked this pull request as ready for review September 12, 2024 09:16
@runephilosof-abtion runephilosof-abtion added the SLA Implement this on our SLA projects label Sep 12, 2024
This was referenced Sep 12, 2024
@runephilosof-abtion
Copy link
Member Author

The gem maintainer is open to adding annotating the exception file/line
Drieam/rspec-github#75
https://github.com/Drieam/rspec-github/pull/76/files

@jeppester
Copy link
Contributor

The gem maintainer is open to adding annotating the exception file/line
Drieam/rspec-github#75
https://github.com/Drieam/rspec-github/pull/76/files

Cool.

I don't like for this PR to stall while we are waiting, let's merge this for the value it gives us already.
Then we can upgrade if it becomes possible to show the exception location.

@jeppester
Copy link
Contributor

@runephilosof-abtion Would you prefer to not merge this just yet?

@runephilosof-abtion runephilosof-abtion merged commit e5ffe16 into main Oct 2, 2024
13 checks passed
@runephilosof-abtion runephilosof-abtion deleted the rspec-github branch October 2, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SLA Implement this on our SLA projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants