Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #590: clarify usage of configuration macros #597

Closed
wants to merge 1 commit into from
Closed

Issue #590: clarify usage of configuration macros #597

wants to merge 1 commit into from

Conversation

rdiachenko
Copy link

@rdiachenko rdiachenko commented Dec 17, 2017 •
edited
Loading

Minor update to README to clarify the usage of configuration macros #590

This is a

  • Breaking change
  • New feature
  • Bugfix

I have

@rdiachenko
Copy link
Author

rdiachenko commented Dec 18, 2017 •
edited
Loading

From Travis:

The command "sudo cmake -DBUILD_SHARED_LIBS=ON ." failed and exited with 1 during .

Is not related to my changes. Looks like develop branch is not stable.

@abumq
Copy link
Owner

abumq commented Jan 3, 2018

Updated manually 32ccda7

@abumq abumq closed this Jan 3, 2018
@rdiachenko rdiachenko mentioned this pull request Jan 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdiachenko @abumq