abusehelper.bots.abusech.ransomwarebot: abuse.ch Ransomware Tracker feed #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omware Tracker feed.
ghost
changed the title
|
Are the "first seen" values missing the |
| info, fileobj = yield utils.fetch_url(self.feed_url) | ||
| except utils.FetchUrlFailed, fuf: | ||
| self.log.error("Download failed: %r", fuf) | ||
| idiokit.stop() |
There was a problem hiding this comment.
Probably a good idea to raise abusehelper.core.bot.PollSkipped here instead of calling idiokit.stop() so that the PollingBot dedup filter won't get emptied.
There was a problem hiding this comment.
Style nitpicking:
except utils.FetchUrlFailed, fuf:
should be written as:
except utils.FetchUrlFailed as fuf:
There was a problem hiding this comment.
More style nitpicking: Please use new-style string formatting ("Download failed: {0!r}".format(...)) for new code.
Also, there's the utils.format_exception(exc) for nice formatting of exceptions, so the above could become (arguably more verbose):
self.log.error("Download failed ({0})".format(utils.format_exception(fuf)))…tches. Style fixes.
|
Looks good to me 👍 |
ghost
pushed a commit
that referenced
this pull request
Mar 9, 2016
abusehelper.bots.abusech.ransomwarebot: abuse.ch Ransomware Tracker feed
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polling bot for abuse.ch Ransomware Tracker feed.