Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat req] allow passing the Elasticsearch endpoint via environment vars #71

Closed
tedder opened this issue Jun 1, 2020 · 1 comment · Fixed by #73
Closed

[feat req] allow passing the Elasticsearch endpoint via environment vars #71

tedder opened this issue Jun 1, 2020 · 1 comment · Fixed by #73

Comments

@tedder
Copy link

tedder commented Jun 1, 2020

Currently it takes some nonstandard leaps to point the proxy to a host in an environment variable. The following is sort of 'pseudocode' for docker config.

doesn't work:

environment: ["ES_URL": "http://blah:9200"]
command: ["-endpoint","${ES_URL}"]

current workarounds:

environment: ["ES_URL": "http://blah:9200"]
command: ["sh", "-c", "aws-es-proxy -endpoint ${ES_URL}"]
command: "aws-es-proxy -endpoint ${ES_URL}"

it'd be nice to do:

environment: ["ES_URL": "http://blah:9200"]
command: [""]

It might be handy for other parameters, but this is the one that tends to vary the most- for instance, in ECS, I can look it up by storing it in ssm and then injecting that into ES_URL of the secrets section.

This is beyond my golang abilities, which is why I'm only putting it as a feature request, not a PR :/

saravanan30erd added a commit to saravanan30erd/aws-es-proxy that referenced this issue Jun 2, 2020
saravanan30erd added a commit to saravanan30erd/aws-es-proxy that referenced this issue Jun 2, 2020
@saravanan30erd
Copy link
Contributor

@tedder Raised the PR for this.

mergebotupgrade referenced this issue in Credify/aws-es-proxy Sep 15, 2020
* do not allow auto redirect to http client

* Updates to README.md

* Cross-compile new version

* Updated docker instructions

* Little fix to docker example

* add basic auth support

* fix version

* Support AWS China ES domain name, and update to use Go 1.11 modules

* add timeout

* Updated link to Kibana

Updated link to Kibana app

* make timeout variable

* Fix casting

* - AWS Elasticsearch endpoint is no longer mandatory
- Added more logging
- Removed all of the annoying log.fatal() messages
- Added option to redirect /_plugin/kibana to /_plugin/kibana/app/kibana this fixes blank pages when running newer versions of Kibana.

* Implementing custom http.Client fixed Kibana blank page issue. Removed added hacks.

* Run 'go mod tidy' for cleanup

* Updated version

* Update docker instructions

* Updated Dockerfile and add CONTRIBUTORS file

* Bump golang to v1.14

* Update README to go1.14

* Issue #70 - add the kbn-xsrf header

* issue #71 - add env var support for endpoint argument

* issue #71 - Update readme

* Add IRSA support

* Updated version number

* cleanup dockerfile

* updates

* image update

* fix build

Co-authored-by: Taiki Sugawara <[email protected]>
Co-authored-by: Muslim AbuTaha <[email protected]>
Co-authored-by: Kamus Hadenes <[email protected]>
Co-authored-by: Mike Wu <[email protected]>
Co-authored-by: Mike Kadin <[email protected]>
Co-authored-by: Rui Chen <[email protected]>
Co-authored-by: saravanan30erd <[email protected]>
Co-authored-by: Luke Addison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants