Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BAD] Automatic PR for 1ca36ea7-5c3b-4d9b-80f1-4180c6781e07 #108

Open
wants to merge 1 commit into
base: 1ca36ea7-5c3b-4d9b-80f1-4180c6781e07-base
Choose a base branch
from

Conversation

code-narrator
Copy link

The PR was created automatically by CodeNarrator. The following issues were fixed:
BLD: improvements to meson.build files (pandas-dev#54949)

  • BLD: some changes to make meson.build more idiomatic
  • Use pure: false only in a single place. This is recommended for
    robustness, this way you can't forget it in a subdirectory and end up
    with a subtly broken package only on niche Linux distros that split
    purelib and platlib directories.
  • Use py.install_sources with a list input rather than in a foreach
    loop.
  • Remove the werror comment: it's never a good idea to enable
    -Werror by default in the build config of a library, that can easily
    break builds. This should be done in one or more CI jobs instead.
  • BLD: run generate_version.py with a shebang, not 'python'

The way this was before can result in build failures. It assumed that
python is a working Python 3.x interpreter, and that is not always
true. See for example this bug report for the exact same thing in
NumPy, where python isn't working for Sage:
numpy/numpy#24514

Meson guarantees that .py scripts with a shebang on the top line will
be run with a Python interpreter (if there's none on the PATH, it can
use the one Meson itself is run with). Hence this is the most robust
way of using run_command on a .py script.
Corresponding commit hash: 3334832

@DawidMakar-acaisoft DawidMakar-acaisoft changed the title Automatic PR for 1ca36ea7-5c3b-4d9b-80f1-4180c6781e07 [BAD] Automatic PR for 1ca36ea7-5c3b-4d9b-80f1-4180c6781e07 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants