Update dependency com.cjbooms:fabrikt to v16

acanda · May 9, 2024 · 0a535f2 · 0a535f2
1 parent 55d875e
commit 0a535f2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -36,7 +36,7 @@ repositories {
 }
 
 dependencies {
-    implementation("com.cjbooms:fabrikt:15.3.0")
+    implementation("com.cjbooms:fabrikt:16.1.0")
     testImplementation(kotlin("test"))
     detektPlugins("io.gitlab.arturbosch.detekt:detekt-formatting:1.23.6")
 }

diff --git a/src/test/kotlin/ch/acanda/gradle/fabrikt/processor/IgnoreUnknownPropertiesProcessorTest.kt b/src/test/kotlin/ch/acanda/gradle/fabrikt/processor/IgnoreUnknownPropertiesProcessorTest.kt
@@ -70,15 +70,12 @@ class IgnoreUnknownPropertiesProcessorTest : StringSpec({
 
         addIgnoreUnknownPropertiesAnnotation(modelsDirectory)
 
-        val modelClass = modelsDirectory.resolve("Animal.kt").readText()
-        modelClass shouldBe """
+        // the base class should not be annotated
+        modelsDirectory.resolve("Animal.kt").readText() shouldBe """
             |package a.b.models
             |
-            |import com.fasterxml.jackson.`annotation`.JsonIgnoreProperties
-            |import com.fasterxml.jackson.`annotation`.JsonProperty
             |import com.fasterxml.jackson.`annotation`.JsonSubTypes
             |import com.fasterxml.jackson.`annotation`.JsonTypeInfo
-            |import javax.validation.constraints.NotNull
             |
             |@JsonTypeInfo(
             |  use = JsonTypeInfo.Id.NAME,
@@ -92,6 +89,16 @@ class IgnoreUnknownPropertiesProcessorTest : StringSpec({
             |  public abstract val type: AnimalDiscriminatorType
             |}
             |
+        """.trimMargin()
+
+        // only the data classes should be annotated
+        modelsDirectory.resolve("Dog.kt").readText() shouldBe """
+            |package a.b.models
+            |
+            |import com.fasterxml.jackson.`annotation`.JsonIgnoreProperties
+            |import com.fasterxml.jackson.`annotation`.JsonProperty
+            |import javax.validation.constraints.NotNull
+            |
             |@JsonIgnoreProperties(ignoreUnknown = true)
             |public data class Dog(
             |  @get:JsonProperty("type")
@@ -100,14 +107,6 @@ class IgnoreUnknownPropertiesProcessorTest : StringSpec({
             |  override val type: AnimalDiscriminatorType = AnimalDiscriminatorType.DOG,
             |) : Animal()
             |
-            |@JsonIgnoreProperties(ignoreUnknown = true)
-            |public data class Cat(
-            |  @get:JsonProperty("type")
-            |  @get:NotNull
-            |  @param:JsonProperty("type")
-            |  override val type: AnimalDiscriminatorType = AnimalDiscriminatorType.CAT,
-            |) : Animal()
-            |
         """.trimMargin()
     }