Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#383 #384

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Feature/#383 #384

merged 3 commits into from
Nov 7, 2024

Conversation

aceisace
Copy link
Member

@aceisace aceisace commented Nov 7, 2024

Implement support for line breaks in text module as suggested in issue #383

@aceisace aceisace added the new feature request For possible new features label Nov 7, 2024
@aceisace aceisace self-assigned this Nov 7, 2024
@aceisace aceisace linked an issue Nov 7, 2024 that may be closed by this pull request
@aceisace aceisace merged commit 6260964 into main Nov 7, 2024
2 checks passed
@aceisace aceisace deleted the feature/#383 branch November 7, 2024 07:52
@aceisace
Copy link
Member Author

aceisace commented Nov 7, 2024

@pascalforget Alright then, I've implemented the line-break feature and ran some tests myself. The unittests are also passing, hence it's now available in the main branch. You can test out the new feature by updating Inkycal:

cd ~/Inkycal
source venv/bin/activate
git pull
# if you get errors, you can also try the following two lines. Warning! This will override all your custom changes
git reset --hard
git pull

python inky_run.py

If the rendering is successful and the line breaks are now showing up as they should, you can reboot the OS to ensure the changes are picked up by the cron job. Please let me know if it works

@pascalforget
Copy link

pascalforget commented Nov 8, 2024 via email

@aceisace
Copy link
Member Author

aceisace commented Nov 8, 2024

Glad to hear it works as expected and thank you for testing and providing feedback! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature request For possible new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: TextModule - Add support for newline
2 participants