Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General - Remove "SwitchWeapon" spam #10113

Merged
merged 5 commits into from
Jul 20, 2024
Merged

General - Remove "SwitchWeapon" spam #10113

merged 5 commits into from
Jul 20, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Jul 12, 2024 •
edited
Loading

When merged this pull request will:

  • Address ToDo: Cleanup all use of "SwitchWeapon" spam #9129. Kept "SwitchWeapon" for weapon holstering though.
  • Improve ace_common_fnc_getWeaponModes
    • by making it return config-case sensitive modes.
    • by fixing this returning two modes. I've never come across this as a firemode, but I've left it, as CBA's function also includes that check.
  • The primary syntax of selectWeapon turns off flashlights and lasers, even if the weapon is already selected. The alt syntax doesn't suffer from this. -> Only use the primary syntax when necessary (multiple changes were done to respect that behaviour).

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added kind/enhancement Release Notes: **IMPROVED:** status/needs-testing labels Jul 12, 2024
@johnb432 johnb432 linked an issue Jul 13, 2024 that may be closed by this pull request
ToDo: Cleanup all use of "SwitchWeapon" spam #9129
Closed
@johnb432 johnb432 marked this pull request as ready for review July 15, 2024 20:32
@johnb432 johnb432 added this to the 3.18.0 milestone Jul 15, 2024
@johnb432 johnb432 merged commit 5cada7d into master Jul 20, 2024
5 checks passed
@johnb432 johnb432 deleted the general-remove-switchWeapon branch July 20, 2024 06:13
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@johnb432 @blake8090
General - Remove "SwitchWeapon" spam (acemod#10113)
c096864 
* Remove "switchWeapon" spam

* Update fnc_startDragLocal.sqf

* Don't add invalid fire modes

* Tweaks & fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.

ToDo: Cleanup all use of "SwitchWeapon" spam
2 participants
@johnb432 @PabstMirror