Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical AI - Fix splints not being applied in special circumstance & setting adding multiple EH #10141

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Medical AI - Fix splints not being applied in special circumstance & setting adding multiple EH #10141

merged 1 commit into from
Jul 24, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Jul 23, 2024 •
edited
Loading

When merged this pull request will:

  • According to the code, if a unit had more than 5 medications in their system they couldn't apply splints. This doesn't make sense to me, so I removed that check.
  • _target could potentially be nil in an instance (I doubt this could happen under normal circumstances, but it's been added as a precaution).
  • Setting could add multiple EH, making the replace function run multiple times. This has been rectified by making the setting require a mission restart.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432
Several medical AI fixes
0b8aac4 
- Not applying splints if too many medications were taken
- Potential nil for _target
- Setting could add multiple EH, require mission restart
@johnb432 johnb432 added the kind/bug-fix Release Notes: **FIXED:** label Jul 23, 2024
@johnb432 johnb432 added this to the 3.18.0 milestone Jul 23, 2024
veteran29
veteran29 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnb432 johnb432 merged commit 74de646 into master Jul 24, 2024
5 checks passed
@johnb432 johnb432 deleted the medical-ai-code-fixes branch July 24, 2024 13:04
blake8090 pushed a commit to blake8090/ACE3 that referenced this pull request Aug 18, 2024
@johnb432 @blake8090
Medical AI - Fix splints not being applied in special circumstance & …
4ee8717 
…setting adding multiple EH (acemod#10141)

Several medical AI fixes

- Not applying splints if too many medications were taken
- Potential nil for _target
- Setting could add multiple EH, require mission restart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@veteran29 veteran29 veteran29 approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @veteran29 @LinkIsGrim