Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced Fatigue - Fix stamina costs when not touching ground #10297

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Advanced Fatigue - Fix stamina costs when not touching ground #10297

merged 3 commits into from
Sep 11, 2024

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror commented Sep 6, 2024 •
edited
Loading

Followup to #9714

  • Fix diving (will drain full stamina bar in seconds when moving up)
  • Fix terrain cost when walking on buildings

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Sep 6, 2024
@PabstMirror PabstMirror added this to the 3.18.0 milestone Sep 6, 2024
@johnb432 johnb432 self-requested a review September 6, 2024 07:47
@LinkIsGrim
Copy link
Contributor

What if the building is inclined or you're going up stairs?

@PabstMirror
Copy link
Contributor Author

_fwdAngle is still based on movement and won't be effected

@PabstMirror PabstMirror changed the title AF - Fix diving and terrain costs when not touching ground Advanced Fatigue - Fix diving and terrain costs when not touching ground Sep 11, 2024
@PabstMirror PabstMirror marked this pull request as ready for review September 11, 2024 22:19
@LinkIsGrim LinkIsGrim changed the title Advanced Fatigue - Fix diving and terrain costs when not touching ground Advanced Fatigue - Fix stamina costs when not touching ground Sep 11, 2024
@LinkIsGrim LinkIsGrim merged commit fdf3198 into master Sep 11, 2024
8 checks passed
@LinkIsGrim LinkIsGrim deleted the afTerrainDiver branch September 11, 2024 22:36
@johnb432
Copy link
Contributor

Given these bugs were introduced in #9714, I'll add the ignore-changelog tag.

@johnb432 johnb432 added the ignore-changelog Release Notes: Excluded label Sep 11, 2024
@Drofseh Drofseh mentioned this pull request Sep 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@johnb432 johnb432 Awaiting requested review from johnb432

Assignees
No one assigned
Labels
ignore-changelog Release Notes: Excluded kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PabstMirror @LinkIsGrim @johnb432