Goggles - Add effect event for API #10314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkIsGrim
reviewed
Sep 13, 2024
|
slight preference to just give first 2 args and let the listener call isVisable |
|
isVisible isn't public though |
Maybe we should make it public - not sure if it would have many uses though. |
|
I only need unit as argument, maybe cause. So feel free to change it, i just did it with Grim suggestion |
LinkIsGrim
reviewed
Sep 17, 2024
|
Goggle visibility function is public and I can't read |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
I need API for new addon for KAM that gives event when one of these effects are applied. @LinkIsGrim helped me with making it more general event but i am not sure if documentation is done right.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.